Updated browse endpoint to use parse_comma_separated_list#12228
Merged
RayBB merged 2 commits intointernetarchive:masterfrom Mar 31, 2026
Merged
Updated browse endpoint to use parse_comma_separated_list#12228RayBB merged 2 commits intointernetarchive:masterfrom
RayBB merged 2 commits intointernetarchive:masterfrom
Conversation
RayBB
reviewed
Mar 31, 2026
| q: Annotated[str, Query()] = "", | ||
| subject: Annotated[str, Query()] = "", | ||
| sorts: Annotated[str, Query()] = "", | ||
| sorts: Annotated[list[str] | None, BeforeValidator(parse_comma_separated_list), Query()] = None, |
Collaborator
There was a problem hiding this comment.
Can we make it so sorts is always a list instead of None, kinda like we did here https://github.com/internetarchive/openlibrary/pull/12205/changes#diff-39d528888787932afade59696b3c0f3c22ed46bd1c0a4599f5806e1a185bebb3R234
Sanket17052006
force-pushed
the
update-browse
branch
from
e2f2b30 to
89361a5
Compare
RayBB
approved these changes
Mar 31, 2026
Collaborator
RayBB
left a comment
RayBB
left a comment
There was a problem hiding this comment.
Put on testing and it's working as expected. Thanks for doing this one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #12006
Changes :
sorts_list = [s.strip() for s in sorts.split(",") if s.strip()]in the /browse.json withparse_comma_separated_list.Screenshot
N/A
Stakeholders
@RayBB