make BookPageListsPartial async#12272
Conversation
RayBB
left a comment
RayBB
left a comment
There was a problem hiding this comment.
Looks like it's on the right track. Just one small fix and then I will test it later.
|
|
||
| # Do checks and render | ||
| lists = get_lists(keys) | ||
| lists = await get_lists_async(keys) |
There was a problem hiding this comment.
Please make this public using the same public method but dropping the function name. You can see examples of this in some of the other pull requests for the main issue.
There was a problem hiding this comment.
Thanks for the quick review, I updated my changes.
Sanket17052006
force-pushed
the
async-BPListspartial-12270
branch
from
bcadd44 to
eb10995
Compare
github-project-automation
Bot
moved this to Waiting Review/Merge from Staff
in Ray's Project
RayBB
left a comment
RayBB
left a comment
There was a problem hiding this comment.
Nice job with this one.
After some investigation, turns out we don't need the public version at all because it isn't used in any templates! I looked very closely for this and deployed to testing to verify it's working as expected. (the BPL partial is working on edition pages like https://testing.openlibrary.org/books/OL22829346M/Software. )
Keep up the good work 👍
github-project-automation
Bot
moved this from Waiting Review/Merge from Staff
to Done
in Ray's Project
Co-authored-by: RayBB <RayBB@users.noreply.github.com>
2 participants
Closes #12270
Changes :
get_liststoget_lists_asyncget_lists = async_bridge.wrap(get_lists_async)generate_async()toBookPageListsPartialwhich callsawait get_lists_async()Technical
Testing
docker compose run --rm home make testdocker compose run --rm home make lintScreenshot
N/A
Stakeholders
@RayBB