Update Copilot i18n guidelines for reviews#12274
Merged
RayBB merged 1 commit intointernetarchive:masterfrom Apr 3, 2026
Merged
Update Copilot i18n guidelines for reviews#12274RayBB merged 1 commit intointernetarchive:masterfrom
RayBB merged 1 commit intointernetarchive:masterfrom
Conversation
github-project-automation
Bot
moved this to Waiting Review/Merge from Staff
in Ray's Project
tfmorris
approved these changes
Apr 3, 2026
Contributor
tfmorris
left a comment
tfmorris
left a comment
There was a problem hiding this comment.
Looks great. Thanks for tackling this. I think the HTML piece is clearer now too.
github-project-automation
Bot
moved this from Waiting Review/Merge from Staff
to Done
in Ray's Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12258
Updates the Copilot review guidance for i18n by asking it to flag user visible strings built with concatenation and to prefer named placeholders over positional ones.
Stakeholder
@tfmorris