Restore z-index on #test-body-mobile to fix header dropdown stacking#12275
Merged
cdrini merged 2 commits intointernetarchive:masterfrom Apr 3, 2026
Merged
Restore z-index on #test-body-mobile to fix header dropdown stacking#12275cdrini merged 2 commits intointernetarchive:masterfrom
cdrini merged 2 commits intointernetarchive:masterfrom
Conversation
The z-index was removed in internetarchive#12126 to allow fixed-position popovers to escape the stacking context, but this caused header menus and search autocomplete to render behind the sticky nav-bar.
lokesh
added
the
Priority: 0
cdrini
approved these changes
Apr 3, 2026
Collaborator
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Lgtm! Tested and worked on testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The z-index was removed in #12126 to allow the new ol-popovers that use fixed position to escape the stacking context, but this introduced a bug that caused header menus and search autocomplete to render behind the sticky nav-bar.
This brings back those z-index values and fixes the stacking bug in master. As for the popover issue, I'll revisit it after some more evaluation of our z-index usage in the codebase.
Testing
Visit book page and click the Browse menu option in the header and open up the Search autocomplete by typing in a query.
Screenshot
Before
After
Stakeholders
@mekarpeles @cdrini