Merged
Conversation
Member
|
I agree that it nudge is important but I don't think we want to close it after 7 days |
mekarpeles
reviewed
Apr 3, 2026
| with: | ||
| only-pr-labels: "Needs: Submitter Input" | ||
| days-before-issue-stale: -1 # disable issue stale | ||
| days-before-pr-close: 7 |
Collaborator
Author
There was a problem hiding this comment.
It's a bit confusing, but this is, indeed, closing it seven days after it has been labeled as "stale"
https://github.com/actions/stale?tab=readme-ov-file#days-before-close
The idle number of days before closing the stale issues or the stale pull requests (due to the stale label).
The issues or the pull requests will be closed if the last update (based on GitHub issue field updated_at) is older than the idle number of days.
Since adding the stale label will alter the last update date, we can calculate the number of days from this date.
Disable automatic closing of stale pull requests.
Collaborator
Author
|
@mekarpeles I updated this to not close any issues. Just add a comment to them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a call today with @lokesh @mekarpeles and @cdrini we discussed adding a bot to help nudge PRs that are waiting on submitter input.
The goal here is twofold:
How this does this:
Needs: Submitter Inputthey know the process will be taken care of for them to nudge the contributor.Another benefit of this is when PRs are automatically closed with no activity is that this should make it easier for folks to find issues to work on that have been stale.
In practice this is a rather minor and incremental change to our workflow.
At present only 4 PRs would get a message encouraging them to follow up:
It may seem like if it effects so few PRs then why does it matter?
I want to emphasize, that this is an experiment to help us deal with many new contributors and an enormous backlog of PRs to review. It may seem a little impersonal to have this added but in the big picture it should give make more time having those important connections and conversations instead of just asking someone to please follow up. As such, we can always revert this if it turns out to be too noisy or problematic.
Prior Art
This complements our existing pm_stale_ticket_labeler.yml workflow, which silently labels assigned issues as
Needs: Review Assigneeafter 14 days of inactivity (but never closes anything). This new workflow takes the next step by actually following up with PR authors and closing when there's no response.Again, I'll emphasize there's a lot of possibilities here like maybe in the future we should unassign them from the issue when we close the PR. However, we can keep it as baby steps.
Technical
Testing
Screenshot
Stakeholders