Merged
Conversation
cdrini
added
Priority: 1
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables HTTP/2 in the Docker nginx site configs for the main Open Library web frontend and the covers service, as a follow-up to the nginx config update in #12076.
Changes:
- Enable HTTP/2 for
openlibrary.orgnginx server block viahttp2 on;. - Enable HTTP/2 for
covers.openlibrary.orgnginx server block viahttp2 on;.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
docker/web_nginx.conf |
Turns HTTP/2 back on for the openlibrary.org server block. |
docker/covers_nginx.conf |
Turns HTTP/2 back on for the covers.openlibrary.org server block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addendum to #12076 . It seems like the http2 directive doesn't "inherit" how the listen directive did? Or something like that.
Technical
Testing
Patch deploy on www and covers, and I see HTTP/2 requests streaming through the logs again.
Screenshot
Stakeholders