refactor: replace hardcoded spacing values with semantic tokens#12294
Merged
lokesh merged 5 commits intointernetarchive:masterfrom Apr 7, 2026
Merged
refactor: replace hardcoded spacing values with semantic tokens#12294lokesh merged 5 commits intointernetarchive:masterfrom
lokesh merged 5 commits intointernetarchive:masterfrom
Conversation
Contributor
Author
Bundle Size Note
Should the limit in |
github-actions
Bot
added
the
Needs: Response
- headings.css: restore 22px padding-left on .merge span to prevent text overlapping the 16px background icon - buttonCta.css: restore 1px margin-left on .cta-button-group items to preserve the connected button group appearance - edit-toolbar--tablet.css: replace primitive --spacing-3xs with semantic tokens Made-with: Cursor
lokesh
approved these changes
Apr 7, 2026
Collaborator
lokesh
left a comment
lokesh
left a comment
There was a problem hiding this comment.
Looks great! I made a couple of edits:
- Reverted padding-left on h4.facetHead span.merge back to 22px, this value must exceed the 16px background icon width to prevent text overlap.
- Reverted margin-left on .cta-button-group > .cta-btn back to 1px. The 1px gap is intentional for the connected button group appearance
lokesh
added
Needs: Testing
and removed
Needs: Response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #11555
refactor
Technical
Replaces hardcoded spacing values across base and component CSS files
with semantic spacing tokens from the design token system. This improves
consistency and maintainability by centralizing spacing decisions.
Files changed:
static/css/base/— common.css, dl.css, headings.css, helpers-common.css, helpers-misc.cssstatic/css/components/— carousel.css, buttonCta.css, buttonBtn.css,buttonGhost.css, buttonLink.css, buttonsAndLinks.css, book.css, cbox.css,
check-in.css, diff.css, admin-table.css, author-infobox.css,
category-item.css, chart.css, chart-stats.css, compact-title.css,
edit-toolbar--tablet.css
Testing
npm run lint:css— should pass with no errorsnpm run build-assets:css— should compile successfullylocalhost:8080and check:/books/OL24152177M/Robinson_Crusoe/subjects/fantasyScreenshot
Stakeholders
@lokesh