Skip to content

Fix advanced search mobile overflow#12308

Merged
RayBB merged 3 commits intointernetarchive:masterfrom
KevinSailema:12304/fix/advanced-search-mobile-overflow
Apr 7, 2026
Merged

Fix advanced search mobile overflow#12308
RayBB merged 3 commits intointernetarchive:masterfrom
KevinSailema:12304/fix/advanced-search-mobile-overflow

Conversation

@KevinSailema
Copy link
Copy Markdown
Contributor

@KevinSailema KevinSailema commented Apr 6, 2026

Closes #12304

fix

Technical

  • Added a mobile-only CSS override scoped to Advanced Search.
  • Set the Advanced Search form container to width: 100% for small screens.
  • Set Advanced Search text inputs (qtop-*) to width: 100%, margin-right: 0, and box-sizing: border-box.
  • Kept the implementation narrow to avoid regressions on other pages that also load shared user page styles.

Testing

  1. Run: docker compose run --rm home make css
  2. Run: docker compose up -d
  3. Open: http://localhost:8080/advancedsearch
  4. In responsive mode (for example 320 x 696), verify all Advanced Search text inputs fit within the viewport and no horizontal overflow appears.
  5. Smoke-check other search pages (authors, subjects, inside, lists) to confirm no layout regressions from this change.

Screenshot

  • Mobile viewport evidence attached in PR showing Advanced Search without input overflow.
Screenshot 2026-04-06 at 4 12 06 PM

Stakeholders

@RayBB @lokesh

Copilot AI review requested due to automatic review settings April 6, 2026 21:16
@github-project-automation github-project-automation Bot moved this to Waiting Review/Merge from Staff in Ray's Project Apr 6, 2026
@RayBB RayBB requested review from lokesh and removed request for Copilot April 6, 2026 21:18
Comment thread static/css/legacy.css Outdated
Comment thread static/css/legacy.css Outdated
Copilot AI review requested due to automatic review settings April 7, 2026 00:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Advanced Search page’s horizontal overflow on small screens by scoping a narrow, mobile-only width override to the advanced search form and its text inputs.

Changes:

  • Added a mobile breakpoint rule to make the Advanced Search form and its inputs span width: 100% and remove the right margin.
  • Added scoped CSS classes (siteSearch--advanced, siteSearch--advanced-input) to the Advanced Search template to avoid impacting other pages.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
static/css/legacy.css Adds a max-width 768px override for Advanced Search form/input sizing to prevent mobile overflow.
openlibrary/templates/search/advancedsearch.html Adds CSS classes to the form and its text inputs so the new mobile styles are narrowly scoped.

Comment thread static/css/legacy.css Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@RayBB RayBB requested a review from lokesh April 7, 2026 00:12
Copy link
Copy Markdown
Collaborator

@lokesh lokesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this one!

@RayBB
Copy link
Copy Markdown
Collaborator

RayBB commented Apr 7, 2026

@lokesh thanks for reviewing!

@RayBB RayBB merged commit 7200c38 into internetarchive:master Apr 7, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting Review/Merge from Staff to Done in Ray's Project Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

advanced search page overflows on mobile

4 participants