Enable end-of-file-fixer for all file types in pre-commit

[Saad259]

Closes #12327

Technical

Updates pre-commit-config.yaml to enable the end-of-file-fixer hook for all file types, replacing the previous types_or: [python] restriction. Adds an exclude pattern for .po, .pot, .svg, .ini and .type files that should not be modified by the hook.

Testing

Run pre-commit run end-of-file-fixer --all-files and verify it runs across all file types without erroring on excluded files (SVG, po, pot, ini).

Screenshot

N/A no UI changes

Stakeholders

@RayBB

[Saad259]

Hi @RayBB the pre-commit.ci bot was unable to auto-fix this PR with the message: "GitHub prevented pre-commit.ci from autofixing this PR due to autofixes to a workflow file". It does say 0 errors found so I'm not sure what exactly happened here. How would you like me to proceed?

[mekarpeles]

Thanks for the PR, @Saad259!

🤖 Copilot has been assigned for an initial review.

@RayBB is assigned to this PR and currently has:

• 3 open PR(s) of equal or higher priority to review first

PR triage checklist (maintainers / Pam)

• PR description — not empty; explains what the change does and how to verify it
• References an issue — PR body contains a #12327 reference
  • Linked issue is triaged — has Priority: 3
  • Linked issue is assigned — has at least one assignee
• Commit history clean — single clean commit
• CI passing — no failing check-runs
• Test cases present — config-only change; no logic requires testing
• Proof of testing — testing steps provided in PR body

Note

This comment was automatically generated by Pam, Open Library's Project AI Manager, on behalf of @mekarpeles. Pam is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting.

[Copilot]

Pull request overview

Updates the repository’s pre-commit configuration so the end-of-file-fixer hook applies broadly (not just Python), reducing diff noise from missing final newlines while avoiding known file types that shouldn’t be touched.

Changes:

• Removed the types_or: [python] restriction from end-of-file-fixer so it runs across all applicable (text) files.
• Added an exclude regex to skip .po, .pot, .svg, .ini, and .type files.

[RayBB]

Thanks for working on this!

I went through and confirmed that all the files that are changing are not breaking any standards (aka there are similar files in the codebase that have a newline). So no files are changed in a way that makes them out of step with other files.

Fun additional reading about why the newline is good:
https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline