Default request context lang to 'en' to silence unhelpful error logs#12336
Merged
RayBB merged 1 commit intointernetarchive:masterfrom Apr 9, 2026
Merged
Default request context lang to 'en' to silence unhelpful error logs#12336RayBB merged 1 commit intointernetarchive:masterfrom
RayBB merged 1 commit intointernetarchive:masterfrom
Conversation
github-project-automation
Bot
moved this to Waiting Review/Merge from Staff
in Ray's Project
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents request-context initialization from failing when a language isn’t present on web.ctx / request.state, by defaulting the request-context lang to "en". This addresses the AttributeError: 'ThreadedDict' object has no attribute 'lang' reported in #12070, especially for scripts/crons/background-thread execution paths that don’t fully populate web.ctx.
Changes:
- Default
RequestContextVars.langto"en"whenweb.ctx.langis missing/falsey in the legacy web.py context setup. - Default
RequestContextVars.langto"en"whenrequest.state.langis falsey in the FastAPI context setup.
RayBB
approved these changes
Apr 9, 2026
Collaborator
RayBB
left a comment
RayBB
left a comment
There was a problem hiding this comment.
We discussed this and walked through it on the call. This is what we need to stop some error messages.
github-project-automation
Bot
moved this from Waiting Review/Merge from Staff
to Done
in Ray's Project
cdrini
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12070 . This was also causing the error logs to explode in size on our prod cluster, so needed some intervention.
Technical
Testing
Tested on testing, and the logs are quiet again!
Screenshot
Stakeholders