Delete component and logic on deleting series created

[IvanPisquiy06]

Closes #12298

Superlibrarians can now delete series directly from the edit page, without needing database or code access. This helps clean up unused, duplicate, or mistakenly created series (e.g. test entries) without requiring maintainer intervention.

Technical

A new Lit web component OLDeleteBtn (ol-delete-btn) was added to openlibrary/components/lit/ and exported via the existing index.js entry point, so it is automatically included in the Vite bundle at static/build/lit-components/production/ol-components.js.

The component is fully generic and reusable — the button label, item name, item count, and linked items label are all configurable via attributes, making it usable beyond series (e.g. lists).

databarEdit.html was updated to render the component for both series and list edit pages, gated behind the existing admin/super-librarian permission check. The list_type variable drives a Python code block that sets the appropriate label and linked-label values. The form submission is handled by an existing event listener in edit.html that responds to the ol-delete-btn-confirm custom event.

The series deletion logic mirrors the existing list deletion logic, reusing the same patterns to avoid duplication.

Testing

1. Log in as an admin or super-librarian.
2. Navigate to a series edit page.
3. Confirm the "Delete Series" button appears in the edit toolbar.
4. Click the button — a confirmation dialog should appear with the series name and linked work count.
5. Confirm the deletion — the series should be deleted and you should be redirected.
6. Repeat steps 2–5 on a list edit page and confirm "Delete List" appears and behaves correctly.
7. Log in as a regular user and confirm the delete button does not appear on either page.

Screenshot

Edit page of a Series:

Confirmation message:

Component reused on edit page of a List:

Stakeholders

@cdrini

[mekarpeles]

Thanks for the PR, @IvanPisquiy06.

@cdrini is assigned to this PR and currently has:

• 5 open PR(s) of equal or higher priority to review first

PR triage checklist (maintainers / Pam)

• PR description — not empty; explains what the change does and how to verify it
• References an issue — PR body contains a #NNN reference
  • Linked issue is triaged — has a Priority: * label (not just Needs: Triage)
  • Linked issue is assigned — has at least one assignee
• Commit history clean — no WIP/fixup/conflict noise; commit messages are meaningful
• CI passing — no failing check-runs
• Test cases present — if the change touches substantive logic, test coverage exists or is explained
• Proof of testing — PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by Pam, Open Library's Project AI Manager, on behalf of @mekarpeles. Pam is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting.

[Copilot]

Pull request overview

Adds a reusable Lit “delete with confirmation” button to list/series edit pages and implements server-side series deletion (including cleanup of series edges on linked works) so superlibrarians/admins can delete series from the UI.

Changes:

• Added new Lit web component ol-delete-btn and exported it via the Lit components entry point.
• Updated the edit toolbar macro and list edit template to render and wire up the delete button.
• Extended list/series deletion logic in lists.py, including removing series edges from linked works before deleting a series.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
openlibrary/templates/type/list/edit.html	Passes list_type into databarEdit and adds a document-level handler to submit deletion via _delete=true.
openlibrary/plugins/openlibrary/lists.py	Intercepts _delete on edit POST; expands delete endpoint to support series; removes series edges from works before series deletion.
openlibrary/macros/databarEdit.html	Adds a delete button web component into the edit toolbar (currently not restricted to list/series pages).
openlibrary/components/lit/index.js	Exports the new OLDeleteBtn component from the Lit bundle entry point.
openlibrary/components/lit/OLDeleteBtn.js	Implements the new Lit delete button with confirm dialog + ol-delete-btn-confirm event.

Comments suppressed due to low confidence (1)

openlibrary/plugins/openlibrary/lists.py:472

• lists_delete.path now introduces an extra capturing group (lists|series), but POST(self, key) still only accepts one positional arg. With web.py route matching, this will pass 2 args (key + list_type) and raise a TypeError. Use a non-capturing group (?:lists|series) (or update the handler signature) so the route only captures the full key once.

class lists_delete(delegate.page):
    path = r"((?:/people/[^/]+)?/(lists|series)/OL\d+L)/delete"
    encoding = "json"

    def POST(self, key):
        if not (user := get_current_user()):

[Copilot]

databarEdit is used by multiple edit templates (authors, tags, books, etc.). This change renders the new delete component for all admin/super-librarian edit pages and calls page.get_seeds(), which many page types don’t implement, causing template rendering errors for admins. Restrict this block to list/series edit pages (e.g., if list_type in ('list','series')) or guard get_seeds() access before calling it.

[Copilot]

The linked_label variable is only set in the else branch (and never for list/series), but the component hard-codes linked-label="$('works')" and ignores linked_label entirely. This makes the macro’s behavior inconsistent and prevents using the intended list-vs-series wording. Define linked_label for each list_type and pass it through (and make sure it goes through the template i18n function).

[Copilot]

OLDeleteBtn hard-codes the confirmation dialog text in English. Since this is user-facing UI and the component is intended to be reusable across pages, it should allow callers to provide translated strings (e.g., via attributes/properties for the different message templates) rather than embedding English-only sentences in the component.

[Copilot]

This listener appends a new hidden _delete input on every confirmation, so repeated clicks can add duplicate _delete fields to the form. Consider reusing an existing hidden input (create it once) or setting form._delete.value = 'true' to keep the DOM stable.

Suggested change

	if (!form) return;
	var input = document.createElement('input');
	input.type = 'hidden';
	input.name = '_delete';
	input.value = 'true';
	form.appendChild(input);
	var input;
	if (!form) return;
	input = form.querySelector('input[name="_delete"]');
	if (!input) {
	input = document.createElement('input');
	input.type = 'hidden';
	input.name = '_delete';
	form.appendChild(input);
	}
	input.value = 'true';