fix: remove duplicate legend in Advanced Search form (#12381)

[rayrishu19-wq]

Technical

Merged the two redundant

tags into one. This removes the duplicate Advanced Search tag which was causing accessibility issues and redundant headings for screen readers.

Testing

Manually verified that the form structure is correct and all input fields remain intact.

Closes #12381

[mekarpeles]

Thanks for the contribution, and welcome to Open Library! This is your first pull request here — glad to have you.

🤖 Copilot has been assigned for an initial review.

The linked issue (#12381) hasn't been triaged yet — triage happens on Mondays and Fridays. There are currently 78 open non-draft PRs ahead of yours in the queue.

PR triage checklist (maintainers / Pam)

• PR description — not empty; explains what the change does and how to verify it
• References an issue — PR body contains a #NNN reference
  • Linked issue is triaged — has a Priority: * label (not just Needs: Triage)
  • Linked issue is assigned — has at least one assignee
• Commit history clean — no WIP/fixup/conflict noise; commit messages are meaningful
• CI passing — no failing check-runs
• Test cases present — if the change touches substantive logic, test coverage exists or is explained
• Proof of testing — PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by Pam, Open Library's Project AI Manager, on behalf of @mekarpeles. Pam is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting.

[Copilot]

Pull request overview

Removes a redundant <fieldset>/<legend> pair in the Advanced Search template to fix duplicated “Advanced Search” announcements for screen readers and simplify the form’s semantic structure.

Changes:

• Merged two consecutive <fieldset class="home"> blocks into a single fieldset.
• Ensured the hidden q input (#qtop) remains within the main fieldset alongside the visible form controls.

[mekarpeles]

Hi @rayrishu19-wq has this been tested? Do you have any screenshots of how it looks (desktop/mobile) to verify merging the tags hasn't introduced any side effects or regressions?

[mekarpeles]

@cdrini please also note PR and comment here...
#12385 (comment)