build: remove tests and partials.py from ruff/black formatting denylist#12405
Merged
RayBB merged 2 commits intointernetarchive:masterfrom Apr 17, 2026
Conversation
These files were previously protected from ruff-format because they were touched by active open PRs. Those PRs have since been merged, so the files should now be formatted by ruff by default. Removed from both ruff-format exclude and black files lists: - openlibrary/plugins/openlibrary/partials.py - openlibrary/plugins/upstream/tests/test_addbook.py - openlibrary/plugins/upstream/tests/test_models.py - openlibrary/tests/core/lists/test_model.py - openlibrary/tests/fastapi/test_partials.py - openlibrary/tests/test_templates.py - scripts/conftest.py - scripts/monitoring/tests/test_fail2ban_monitor.py pre-commit.ci will auto-format these files as needed.
for more information, see https://pre-commit.ci
Contributor
Author
|
@RayBB , are these files changes correct |
RayBB
approved these changes
Apr 17, 2026
Collaborator
RayBB
left a comment
RayBB
left a comment
There was a problem hiding this comment.
Awesome thanks very much for doing this. It's such a big help. I've been fighting with partials a bit today dude to this.
Hopefully we can do the rest of the files soon!
Collaborator
|
@RayBB, please make sure that CI checks are passing before merging branches into master. |
Collaborator
|
@jimchamp the CI checks were passing on this branch before merging. Is there something I'm missing here? |
Collaborator
Collaborator
|
@jimchamp How am I supposed to verify that CI checks are passing if those checks only run after the code is merged into master? This particular check only applies to JS files, which are not touched at all by this PR. |
IvanPisquiy06
pushed a commit
to IvanPisquiy06/openlibrary
that referenced
this pull request
Apr 27, 2026
…st (internetarchive#12405) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
IvanPisquiy06
pushed a commit
to IvanPisquiy06/openlibrary
that referenced
this pull request
Apr 27, 2026
…st (internetarchive#12405) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files were previously protected from ruff-format because they were touched by active open PRs. Those PRs have since been merged, so the files should now be formatted by ruff by default.
Removed from both ruff-format exclude and black files lists:
pre-commit.ci will auto-format these files as needed.
Closes #12260
Technical
Testing
Screenshot
Stakeholders