Fix multiple Connection instances in webpy breaking RunAs#12407
Merged
jimchamp merged 2 commits intointernetarchive:masterfrom Apr 22, 2026
Merged
Fix multiple Connection instances in webpy breaking RunAs#12407jimchamp merged 2 commits intointernetarchive:masterfrom
jimchamp merged 2 commits intointernetarchive:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses intermittent failures of RunAs when invoked from web.py endpoints by ensuring request-scoped site context uses the existing web.ctx.site (and its underlying connection) instead of creating a separate Site/connection instance.
Changes:
- Removed the shared
setup_site()helper and stopped creating a newSiteduring web.py request context setup. - Updated web.py context setup to set the
siteContextVar directly fromweb.ctx.site. - Kept FastAPI behavior creating a
Siteper request and setting its auth token from the request cookie.
mekarpeles
added
the
Priority: 1
jimchamp
approved these changes
Apr 22, 2026
Collaborator
jimchamp
left a comment
jimchamp
left a comment
There was a problem hiding this comment.
This is working in testing, but is not setting author_id in the transaction table in local instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #11918 . Fixes specifically RunAs not working correctly sometimes when triggered from webpy endpoints.
Technical
Testing
Tested locally:
Screenshot
Stakeholders
@RayBB @jimchamp