Update unicode fixer script#12435
Merged
mekarpeles merged 5 commits intointernetarchive:masterfrom Apr 27, 2026
Merged
Conversation
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the one-off migration script which detects and fixes HTML-escaped Unicode entities in OL dump-derived records, improving auditability of writes and ensuring edits are attributed to a bot account.
Changes:
- Adds a Python 3 shebang so the script can be executed directly.
- Wraps record saves in
RunAs('ImportBot')so changes are authored by ImportBot. - Adds a specific
action="unicode-fixup"to saved transactions for easier filtering/analysis in change logs.
jimchamp
commented
Apr 23, 2026
jimchamp
commented
Apr 23, 2026
| data.update(updates) | ||
| web.ctx.site.save(data, comment="Fix HTML entity encoding in Unicode fields") | ||
| with RunAs("ImportBot"): | ||
| web.ctx.site.save(data, comment="Fix HTML entity encoding in Unicode fields", action="unicode-fixup") |
Collaborator
Author
There was a problem hiding this comment.
Is unicode-fixup a suitable event name for these updates? We could also get the record type from the key and use something like f"edit-{type}".
tfmorris
reviewed
Apr 24, 2026
Co-authored-by: Tom Morris <tfmorris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #12224
Makes the following updates to
fix_unicode_html_entities.py:web.ctx.site.saveasImportBotunicode-fixupevent name tosavetransactionsTechnical
RunAsmay still be broken when used in a scripting context. If so, I may try usingopenlibrary/api.pyto update records.Testing
Screenshot
Stakeholders