Add account security check endpoint#12464
Merged
mekarpeles merged 1 commit intomasterfrom Apr 28, 2026
Merged
Conversation
mekarpeles
force-pushed
the
check-email-affected-accounts
branch
7 times, most recently
from
1f18c2d to
c5dd095
Compare
Adds a GET-only endpoint that checks whether the logged-in user's account appears in the account table with thing_id <= 51085470. - URL slug is ISO 8601 with hour granularity (2026-04-28T18Z UTC) - Logged-out visitors receive a login link that redirects back after auth - No email form — login required, preventing oracle enumeration attacks - Incident date (2026-04-28T18Z) displayed in the page header - Result shown with green (not affected) or red (affected) background - "not" emphasized with <em> in the safe result - All user-visible strings wrapped with _() for i18n - Threshold and DB check encapsulated as class var and classmethod on account_security_check
mekarpeles
force-pushed
the
check-email-affected-accounts
branch
from
c5dd095 to
40f0b77
Compare
cdrini
approved these changes
Apr 28, 2026
Collaborator
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Lgtm ; tested on testing all cases and they worked correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /account/security/1777402351— logged-in users are checked automatically against the affected accounts set; logged-out visitors see an email input formPOST /account/security/1777402351— accepts an email, validates it withvalid_email(), and returns a boolean result (affected / not affected)accounttable; SQL injection is not possible_()for i18n; variable interpolation uses OL'swebsafe()keyword-arg patternTest plan
/account/security/1777402351while logged out — email form rendersaccounttable — "not in the affected set"thing_id <= 51085470— "in the affected set"thing_id > 51085470— "not in the affected set"