Skip to content

Fix seen type annotation in author redirects#12739

Merged
mekarpeles merged 1 commit into
internetarchive:masterfrom
charliesheh:fix-seen-type-annotation
May 18, 2026
Merged

Fix seen type annotation in author redirects#12739
mekarpeles merged 1 commit into
internetarchive:masterfrom
charliesheh:fix-seen-type-annotation

Conversation

@charliesheh
Copy link
Copy Markdown
Contributor

Fixes #12738.

Updates the seen set type annotation in find_author from set[dict] to set[str], since it stores author record keys rather than dictionaries.

@jonathandung
Copy link
Copy Markdown

Thanks for the PR

@github-actions github-actions Bot added the Needs: Response Issues which require feedback from lead label May 18, 2026
@mekarpeles mekarpeles merged commit 5df5a27 into internetarchive:master May 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Response Issues which require feedback from lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect type annotation set[dict] in catalog.add_book.load_book.find_author

3 participants