Adding initial Korean translation#12830
Conversation
|
Thank you for contributing, @systil3! Welcome to Open Library — this appears to be your first contribution to the project. 🤖 Copilot has been assigned for an initial review. This PR has no linked issue, so it will go through triage before a reviewer is assigned. Triage runs on Mondays and Fridays. There are currently 66 open non-draft PRs in the queue ahead of yours. Possible improvements for this PR
PR triage checklist (maintainers / Pam)
Note This comment was automatically generated by Pam, Open Library's Project AI Manager, on behalf of @mekarpeles. Pam is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting. |
|
Korean element re-ordering may making this one challenging (hence the python failure). We may need to use flags to disable these tests for Korean |
fix some typo and add <!-- i18n-lint no-tree-equal --> flag to some terms
I've made a commit after adding the flag for some terms where the change in order of HTML elements is inevitable due to the structure of Korean sentences, and correcting some typos. |
for more information, see https://pre-commit.ci
Overview
Adds an initial Korean (ISO 639-1:
ko) translation for Open Library.Korean is spoken by approximately 80 million people worldwide, including large communities in South Korea, North America, etc. This PR creates
openlibrary/i18n/ko/messages.powith translations covering the whole UI element with EN including core features : account management, borrowing, book editing, navigation, and notifications. This also modifies get_supported_languages() ofopenlibrary/code.pyas adding one line to apply Korean mapping.This contribution aims to make Open Library more accessible to Korean-speaking users.
Technical
All msgid strings were translated to natural, commonly-used Korean.
Since Korean does not grammatically distinguish singular from plural in the same way English does, we set all plural msgstr entries to use index [0] only.
Technical terms or proper nouns without established Korean equivalents (e.g. "Internet Archive", "eBook", "ISBN", "reCAPTCHA", "Adobe Digital Editions") were kept in their original form exceptionally.
Testing
As indicated in the internationalization section of the open library docs, you can build the modifications using the line
docker compose run --rm -uroot home make i18nand validate them using the linedocker compose exec -uroot web ./scripts/i18n-messages validate ko.Screenshot
Stakeholders
@gladmanhh : helped modify line around 5800 ~ 8700 of messages.po
@hajicastle : helped line 2900~5800