Fix KeyError in promise_batch_imports.py script#12835
Open
jimchamp wants to merge 2 commits into
Open
Conversation
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a KeyError in the promise_batch_imports.py cron job by switching from bracket indexing to .get() lookups when extracting the SKU fields from a promise item record, and gracefully skipping records that lack any SKU.
Changes:
- Use
dict.get()forBookSKUB,BookSKU, andBookBarcodeinmap_book_to_olbook, logging and returningNonewhen no SKU is found. - Filter out
Noneresults from the generator passed intobatch_importusing an assignment expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The promise item cron job is sometimes failing with a
KeyErrorwhen attempting to access theskuin a promise item record. This occurs within themap_book_to_olbookfunction.This branch updates the code to use the
getmethod to access this data. If askuis not found, the promise item's json is logged, andNoneis returned bymap_book_to_olbook.Technical
Testing
Screenshot
Stakeholders