Add subject merge request flow tool#12839
Conversation
5619046 to
43abd79
Compare
63251a8 to
43abd79
Compare
|
How it currently works:
Technical Details: Frontend: search/subjects.html was updated to surface data-subject-id. SelectionManager.js was given a new regex hook (^/search/subjects$) that recognizes this type and builds the /subjects/merge?records=... URL. Form Route: The new merge_subjects class in subjects.py handles the page rendering safely by normalizing the prefixes (e.g. person:tolkien) and fetching the latest display data. Database Insertion: The POST request from the form passes the IDs through process_merge_request, inserting a record into community_edits_queue mapped to our new SUBJECT_MERGE type constant. Dashboard Filtering: edits.py computes the query parameters for filtering Works/Authors/Subjects in the backend, resolving web.py's strict template limits by passing the toggles down cleanly via the context dictionary into table_header.html. What is NOT included yet: |
7c12f59 to
f58b2a7
Compare
| <div class="flex-auto"></div> | ||
| <div class="mr-dropdown" id="type-menu-button">$_('Type ▾') | ||
| <div class="mr-dropdown-menu sort hidden"> | ||
| <header class="dropdown-header"> |
There was a problem hiding this comment.
Best Practice: Page has multiple banner landmarks.
Page should not have more than one banner landmark.
Details
The banner landmark (typically <header>) identifies site-oriented content like logos and search. Only one top-level banner is allowed per page. If you need multiple headers, nest them inside sectioning elements (article, section, aside) where they become scoped headers rather than page-level banners.
for more information, see https://pre-commit.ci
|
@jimchamp suggests: It may be helpful to know which works are affected (instead of a count). It's probably not feasible to print all titles, but maybe a small number would help? It's hard to tell the type of each MR at a glance. It may seem to a reviewer that they are reviewing a work merge, only to be taken to the merge subject view. |
|
ref: #65
Summary
Adds a subject merge request flow that follows the existing community edit request workflow.
What changed
/subjects/mergepagecommunity_edits_queueasSUBJECT_MERGECurrent behavior
This branch creates and tracks subject merge requests, but it does not yet execute the actual
subject record merge.
Pending work
Video
Screencast.from.2026-06-03.00-00-47.mp4
Notes
This is meant to establish the direction of the tool and the queue integration first, before
wiring in the final merge execution.