feat: open BookReader with search panel visible on Preview#12855
Open
mekarpeles wants to merge 2 commits into
Open
feat: open BookReader with search panel visible on Preview#12855mekarpeles wants to merge 2 commits into
mekarpeles wants to merge 2 commits into
Conversation
Appends &q= to the BookReader embed URL so that clicking Preview opens BookReader with the search-inside panel already open, making full-text search discoverable without requiring patrons to find the search icon themselves. Depends on: internetarchive/bookreader#<pr-number> Closes: #11912
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the BookReader embed URL used by the “Preview” button so BookReader opens with the search-inside panel visible by default (via an empty q query parameter), improving discoverability of full-text search from the first interaction.
Changes:
- Append
q=to the BookReader embed URL used in the Preview modal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Appends
&q=to the BookReader embed URL in the Preview button so that clicking "Preview" on a book opens BookReader with the search-inside panel already visible.Currently patrons who click "Preview" get a book reader with no obvious indication that full-text search exists. With this change, the search panel opens automatically, making search-inside discoverable from the first interaction.
Depends on: internetarchive/bookreader#1550 (must deploy before this takes effect)
Change
openlibrary/macros/BookPreview.html— 1 lineAdded
&q=to thedata-iframe-srcURL passed to the BookReader embed. BookReader #1550 treats?q=(empty) as a signal to open the search panel on load without running a search.Testing
Once internetarchive/bookreader#1550 is deployed to archive.org:
References
Closes #11912