fix(home): prevent text clipping in onboarding cards#12864
fix(home): prevent text clipping in onboarding cards#12864Armansiddiqui9 wants to merge 3 commits into
Conversation
|
Thanks for the PR! 🤖 Copilot has been assigned for an initial review. The linked issue (#12854) hasn't been triaged yet — triage happens on Mondays and Fridays. There are currently 72 open non-draft PRs ahead of yours. PR triage checklist (maintainers / Pam)
Note This comment was automatically generated by Pam, Open Library's Project AI Manager, on behalf of @mekarpeles. Pam is designed to provide status visibility, perform basic project management functions and relevant codebase research, and provide actionable feedback so contributors aren't left waiting. |
There was a problem hiding this comment.
Pull request overview
This PR aims to fix text clipping in the homepage onboarding carousel cards (especially on mobile / with longer translated strings) by making the card layout content-aware instead of fixed-height/float-based.
Changes:
- Updates onboarding card layout rules to use flex sizing and allow the link container to grow (
height→min-height, addgap, prevent flex overflow viamin-width: 0). - Adjusts text styling to remove percentage-based margins and improve wrapping behavior for long strings.
- (Unintended) Removes a large set of homepage CSS rules that appear to still be required by other homepage sections (Stats + About/Resources).
Closes #12854
Fix: Text clipping in onboarding cards on mobile
Technical
.tutorial__item aused a fixed height (100px)Testing
This PR includes a more robust refactor of the onboarding card layout (moving from fixed-height + float-based layout to a flex-based responsive layout).
Because several legacy layout rules were removed, this change should be visually verified across:
If any regressions are found, a minimal fallback fix is available:
heighttomin-heightadjustment onlyThis ensures the fix can be safely adjusted without blocking the bug resolution.
Screenshot
With language as English, it looks totally perfect

With another language the width of boxes increases

On mobile view width it

Stakeholders