WIP: Taking jQuery UI off the critical path#2423
Closed
jdlrobson wants to merge 2 commits intointernetarchive:masterfrom
Closed
WIP: Taking jQuery UI off the critical path#2423jdlrobson wants to merge 2 commits intointernetarchive:masterfrom
jdlrobson wants to merge 2 commits intointernetarchive:masterfrom
Conversation
Closed
jdlrobson
force-pushed
the
2340
branch
2 times, most recently
from
5e42689 to
fdcc08d
Compare
jdlrobson
force-pushed
the
2340
branch
2 times, most recently
from
3ab7e81 to
3bbb438
Compare
cdrini
added
the
State: Work In Progress
Collaborator
Author
1) ol_confirm_dialog relates to dialogs so should be inside dialog.js as a new function confirmDialog The behaviour for ol_confirm_dialog is modified to only initialise the dialog inside the click handler. 2) the code inside automatic initialises some tabs so should be inside tabs * tabs:not(.ui-tabs) selector is moved from automatic.js to call to initTabs * autohash logic is moved from automatic.js moved to tabs.js ($.support.opacity check is unnecessary as its always supported on our browser matrix)
We use jQuery UI for a handful of things - changing covers, opening dialogs and tabs. We don't have these on all pages, so this change sets up temporary placeholders that load the additional code only when needed. Note the code will still load on the majority of pages, but in a3757ee we will limit the loading of this library to user actions. For instance dialogs, tabs are invoked on works page for cover management when they only need to be loaded when the button is clicked. Fixes: internetarchive#2340
Collaborator
Author
|
Blocked on #2697 - after which I can drop the WIP status and repost with testing instructions. |
Collaborator
Author
|
Closing in favor of #2709 ! |
This was referenced Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm working towards pulling jquery off the critical path. To make code review manageable I will be splitting off pieces of code review one by one.
See: #2421 for first code review.
Closes #2340
Technical
Testing
Evidence