Fix "Want to read" button clipped on mobile#8414
Merged
mekarpeles merged 1 commit intointernetarchive:masterfrom Oct 16, 2023
Merged
Fix "Want to read" button clipped on mobile#8414mekarpeles merged 1 commit intointernetarchive:masterfrom
mekarpeles merged 1 commit intointernetarchive:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8414 +/- ##
=======================================
Coverage 16.62% 16.62%
=======================================
Files 84 84
Lines 4433 4433
Branches 758 758
=======================================
Hits 737 737
Misses 3212 3212
Partials 484 484 |
RayBB
force-pushed
the
fix/dropper-button-overflow
branch
from
77c6fc2 to
670f535
Compare
Member
|
Thank you! |
cdrini
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been bothering me for a while that the want to read button looks funny in the corners of the button.
It looks like this:
After my PR it looks like this:
PS: I set the width of the dropdown button to match the width of the listen button. But I'm not attached to that change.
screenshot of listen button.
Technical
Had to move the border radius code one level down to be able to hide overflow.
Did a few more small css cleanups while I was in there.
I explain more in the demo video below.
Testing
To see this change locally on search results you might need to enable
my_books_dropperinopenlibrary.ymlScreenshot
Demo and code walkthrough: https://www.loom.com/share/b571d2aefbf4443890f9a9a345f14646
Stakeholders
Related to #8181 so I'll tag @jimchamp