Skip to content

Conversation

@benbdeitch
Copy link
Collaborator

Closes #9715

This feature add some much needed linking to the new Bulk Search feature. It can now be selected from either the 'browse' menu, or the searchbar, with either option redirecting you to the page itself.

Technical

Testing

After loading up your local instance, try out both links. They should redirect you properly.

Screenshot

image
image

Stakeholders

@cdrini

@benbdeitch benbdeitch added the Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] label Aug 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 16.74%. Comparing base (ce16a79) to head (59c6d24).
Report is 162 commits behind head on master.

Files Patch % Lines
openlibrary/plugins/openlibrary/js/SearchBar.js 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9716      +/-   ##
==========================================
+ Coverage   16.06%   16.74%   +0.68%     
==========================================
  Files          90       90              
  Lines        4769     4820      +51     
  Branches      832      841       +9     
==========================================
+ Hits          766      807      +41     
- Misses       3480     3489       +9     
- Partials      523      524       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini added the State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] label Aug 14, 2024
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Aug 26, 2024
@cdrini cdrini removed the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

State: Blocked Work has stopped, waiting for something (Info, Dependent fix, etc. See comments). [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add links to bulk search from search dropdown, search toolbar

4 participants