[PB-5660] feat: favorites page - #2038
Open
victor-ferro wants to merge 12 commits into
Open
Conversation
Add a Favorites view listing favorite files and folders, backed by new SDK endpoints (getFavoriteFolders/getFavoriteFiles), with its own fetch services, Redux thunk, route, sidenav entry and translations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Deploying drive-web with
|
| Latest commit: |
ef035c6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://537eb427.drive-web.pages.dev |
| Branch Preview URL: | https://pb-5660-favorites-page.drive-web.pages.dev |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… view - hide top bar upload/create buttons, background context menu, shift+F shortcut and drag-and-drop in the favorites view - keep state.favorites updated on item rename, deletion and thumbnail cleanup, mirroring the existing recents handling
This was referenced Jul 14, 2026
This was referenced Jul 14, 2026
victor-ferro
marked this pull request as ready for review
July 20, 2026 16:14
CandelR
reviewed
Jul 21, 2026
Comment on lines
+390
to
+398
| const fetchItems = () => { | ||
| if (isTrash) { | ||
| getMoreTrashItems(); | ||
| } else if (isFavorites) { | ||
| dispatch(fetchFavoritesThunk()); | ||
| } else { | ||
| dispatch(fetchPaginatedFolderContentThunk(currentFolderId)); | ||
| } | ||
| }; |
Collaborator
There was a problem hiding this comment.
The DriveExplorer component is already too large and contains a lot of logic for different views, we must avoid adding any more logic there. Separate the Favourites logic from the component
Author
There was a problem hiding this comment.
Done — the favorites logic has been moved out of DriveExplorer: state selection and fetching/reset now live in a useFavoritesPagination hook and the empty state in a FavoritesEmptyState component
| (item: DriveItemData) => !itemsToDelete.find((i) => i.id === item.id && !!i.isFolder === !!item.isFolder), | ||
| ); | ||
| state.favorites = state.favorites.filter( | ||
| (item: DriveItemData) => !itemsToDelete.find((i) => i.id === item.id && !!i.isFolder === !!item.isFolder), |
# Conflicts: # package.json
|
CandelR
reviewed
Jul 27, 2026
CandelR
left a comment
CandelR
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed. Waiting QA approval to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a Favorites page that lists the user's favorite folders and files.
Related Issues
Relates to PB-5660
Related Pull Requests
Checklist
Testing Process
Additional Notes