[PB-5662] feat: favorite toggle from toolbar - #2043
Conversation
Deploying drive-web with
|
| Latest commit: |
25461d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://41d02072.drive-web.pages.dev |
| Branch Preview URL: | https://pb-5662-toolbar-favorite.drive-web.pages.dev |
|
hey! here at drive-web we use the PR template from https://github.com/internxt/drive-web/blob/master/.github/pull_request_template.md Please use it for every PR so we are all aligned. If you think it could be improved or something should be changed, feel free to submit a separate PR for that as well! |
| Link, | ||
| Rows, | ||
| SquaresFour, | ||
| Star, |
There was a problem hiding this comment.
this import is deprecated, use 'StarIcon' instead
nit: you can also fix the rest of the deprecated imports if you want, its basically just adding 'Icon' at the end
There was a problem hiding this comment.
I noticed this too late and corrected it in a subsequent PR
| const buildItem = (isFavorite?: boolean): DriveItemData => ({ uuid: 'uuid', isFavorite }) as DriveItemData; | ||
|
|
||
| describe('getFavoriteToolbarAction', () => { | ||
| it('should return null when no items are selected', () => { |
There was a problem hiding this comment.
nit: we are trying to use test('when... then...) instead of it('should...) for the tests
There was a problem hiding this comment.
Perfect, I'll adjust this one and the rest of the PRs to meet this
|
3 participants
Description
DriveTopBarActions, between Download and Move to trash, following the toolbar's existing button patterntoggleFavoriteThunkfrom PB-5661getFavoriteToolbarAction('add' | 'remove' | null), unit-tested — same precedent asgetListHeaders.tsRelated Issues
Relates to PB-5662
Related Pull Requests
Checklist
Testing Process
yarn vitest run src/views/Drive src/views/Favorites— 16 files, 83 tests passing (against linked SDK), including the 7getFavoriteToolbarActiontestsAdditional Notes
@internxt/sdkdependency as [PB-5660] feat: favorites page #2038/[PB-5661] feat: favorite toggle from context menu and F shortcut #2041 (favorites endpoints; developed against a yarn-linked local SDK). CI will fail until that SDK version is published and bumped.