[scd] Remove redundant fetch cells call#1475
Merged
mickmis merged 1 commit intoJun 2, 2026
Merged
Conversation
mickmis
approved these changes
Jun 2, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
LGTM - good catch! Maybe we will have an improvement in performances too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a redundant call to
fetchCellsForSubscriptionand, inUpsertSubscription, it removes thenewSubscription.Cellsupdate since cells are directly fetched from the DB byfetchSubscription.Test: I used the
check_scd_write.shandcheck_scd_read.shscripts with intermediate logging before and after the additional cells fetch to confirm the redundancy.