[tanka/helm] Actually delete entries in cronjob evict tool#1487
Merged
Conversation
barroco
approved these changes
May 27, 2026
barroco
reviewed
May 27, 2026
barroco
left a comment
barroco
left a comment
Contributor
There was a problem hiding this comment.
Please add a note in release notes.
Member
Author
I updated the existing line, since it's the second fix to make evict job working |
barroco
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems the delete flag was missing from the evict tool cronjob.
It's doesn't really make sense to have them not deleting entries, so no configuration flag has been added (they can be disabled anyway).
Fix #1486
(Not tested locally, but change is simple)