[tanka/helm] Remove 'name' anotation in AWS load balancer#1489
Merged
barroco merged 1 commit intoMay 28, 2026
Conversation
Contributor
|
Please add a note in the release notes. |
the-glu
force-pushed
the
remove_name_annotation_in_aws_lb
branch
from
7aa3912 to
dfdcf71
Compare
Member
Author
Done |
barroco
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'name' annotation enforce the name on AWS load balancer, but that create issues when deploying multiple DSS K8S clusters in the same AWS region.
This PR just remove the annotation, letting AWS doing the naming.
Existing LBs won't be renamed.
Names automatically generated by AWS are still explicit:
This also fix #1189 (but with a different solution, it remove the option to configure the name).