fix(camera): throw error if no activity to pick images is found - #668
Merged
jcesarmobile merged 3 commits intoOct 26, 2021
Merged
Conversation
jcesarmobile
requested changes
Oct 25, 2021
jcesarmobile
left a comment
jcesarmobile
left a comment
Member
There was a problem hiding this comment.
sadly Google put some restrictions on resolveActivity on Android 11 and this change makes the picking images impossible on Android 11 devices as resolveActivity is always returning false.
Can you try using try catch to catch the activity not found error instead of this?
Also, would be helpful if you could provide some way of reproducing this, all my devices have a gallery app that can't be uninstalled.
Contributor
Author
|
thx for your comment. on my own two devices, i could uninstall gallery app. two devices spec is below:
|
jcesarmobile
approved these changes
Oct 26, 2021
jcesarmobile
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if Activity is not found, do not call com.getcapacitor.Plugin.startActivityForResult at CameraPlugin openPhotos and reject.
closes #667