Skip to content

Conversation

@arbouna
Copy link

@arbouna arbouna commented Feb 2, 2017

AppController.getActiveNav() doesn't need to be a private function. We really need this function when it comes to accessing an active NavController from the outside views/handlers like registerBackButtonAction().
getRootNav() won't work well when we have several NavControllers that are stacked into one single Tabs view.

Short description of what this resolves:

Add a new documentation for AppController.getActiveNav()

Changes proposed in this pull request:

  • Brief comment changes

Ionic Version: 2.x

AppController.getActiveNav() doesn't need to be a private function. We really need this function when it comes to accessing an active NavController from the outside views/handlers like registerBackButtonAction().
getRootNav() won't work well when we have several NavControllers that are stacked into one single Tabs view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants