Skip to content

feat(menu): default to overlay for ios menu #19063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 8, 2019
Merged

feat(menu): default to overlay for ios menu #19063

merged 14 commits into from
Oct 8, 2019

Conversation

adamdbradley
Copy link
Contributor

@adamdbradley adamdbradley commented Aug 9, 2019 •
edited by brandyscarney
Loading

fixes #18662

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Aug 9, 2019
@adamdbradley adamdbradley mentioned this pull request Aug 9, 2019
Closed
@brandyscarney brandyscarney changed the base branch from master to next August 12, 2019 19:34
@brandyscarney
Copy link
Member

brandyscarney commented Aug 12, 2019 •
edited
Loading

Updated base to next branch but it pulls in a lot of changes, we need to rebase the branch

@brandyscarney brandyscarney changed the base branch from next to master August 12, 2019 19:34
@brandyscarney brandyscarney changed the base branch from master to next August 12, 2019 19:38
@brandyscarney
Copy link
Member

next was rebased and I updated this PR to fix conflicts, can you make sure I didn't remove any code on accident?

@brandyscarney
Copy link
Member

This needs to be updated with the new animation code.

brandyscarney and others added 9 commits September 27, 2019 16:29
@brandyscarney
refactor(nav): remove nav-push, nav-pop nav-root (#19240)
e334d73 
BREAKING CHANGES

Removes ion-nav-pop, ion-nav-push and ion-nav-set-root in favor of using ion-nav-link with router-direction
@brandyscarney
refactor(scss): remove scss (#19292)
6450aff 
BREAKING CHANGES

Removes `scss` files from the distributed files. Please use CSS variables for theming instead.
@brandyscarney
refactor(themes): update to new ionic colors (#19279)
7f4cf08 
BREAKING CHANGES

The Ionic default colors have been updated to the following:

primary:         #3880ff
secondary:       #3dc2ff
tertiary:        #5260ff
success:         #2dd36f
warning:         #ffc409
danger:          #eb445a
light:           #f4f5f8
medium:          #92949c
dark:            #222428

`primary`, `light` and `dark` have not changed. The contrast color for `warning` has been updated to `#000`.
@brandyscarney
refactor(css): remove CSS util attributes (#18956)
04862df 
BREAKING CHANGES

Removes all CSS utility attributes. Please use CSS classes instead. See the documentation for the correct class names: https://ionicframework.com/docs/layout/css-utilities
@brandyscarney
refactor(skeleton-text): remove width property (#18936)
7c3db79 
BREAKING CHANGES

Skeleton text's `width` property has been removed. Please use CSS instead to set the width.
@brandyscarney
refactor(anchor): remove anchor in favor of router-link (#18935)
e7cd197 
BREAKING CHANGES

The deprecated `ion-anchor` component has been removed in favor using `ion-router-link`. It should still only be used with vanilla and Stencil JavaScript projects. For Angular projects, use an `<a>` and `routerLink` with the Angular router.
@brandyscarney
refactor(searchbar): remove boolean values from showCancelButton (#18953
508e186 
)

BREAKING CHANGES

The `show-cancel-button` property of the searchbar no longer accepts boolean values. Accepted values are strings: `"focus"`, `"always"`, `"never"`. The following should change:

```
<ion-searchbar show-cancel-button>
<ion-searchbar show-cancel-button="true">
<ion-searchbar show-cancel-button="false">
```

becomes

```
<ion-searchbar show-cancel-button="focus">
<ion-searchbar show-cancel-button="focus">
<ion-searchbar show-cancel-button="never">
```
@liamdebeasi
Merge branch 'ios-menu' of https://github.com/ionic-team/ionic into i…
f091c0f 
…os-menu
@liamdebeasi
Merge remote-tracking branch 'origin' into ios-menu
df6daea
@liamdebeasi liamdebeasi merged commit ccb54a1 into next Oct 8, 2019
brandyscarney pushed a commit that referenced this pull request Oct 8, 2019
@adamdbradley @brandyscarney
feat(menu): default to overlay for ios menu (#19063)
ca3c2ec 
resolves #18662
brandyscarney pushed a commit that referenced this pull request Oct 9, 2019
@adamdbradley @brandyscarney
feat(menu): default to overlay for ios menu (#19063)
a9219b0 
resolves #18662
brandyscarney pushed a commit that referenced this pull request Oct 10, 2019
@adamdbradley @brandyscarney
feat(menu): default to overlay for ios menu (#19063)
dbf6a44 
resolves #18662
elylucas pushed a commit that referenced this pull request Oct 30, 2019
@adamdbradley @elylucas
feat(menu): default to overlay for ios menu (#19063)
7f4d84d 
resolves #18662
@liamdebeasi liamdebeasi deleted the ios-menu branch November 11, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adamdbradley @brandyscarney @liamdebeasi @manucorporat