Skip to content

virtualRepeat directive cleanup #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2013
Merged

virtualRepeat directive cleanup #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dist/js/ionic-angular.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26578,6 +26578,10 @@ angular.module('ionic.ui.virtualRepeat', [])
// When the user scrolls, we move the `state.firstActive`
dom.bind('momentumScrolled', sfVirtualRepeatOnScroll);

scope.$on('$destroy', function () {
dom.unbind('momentumScrolled', sfVirtualRepeatOnScroll);
});

// The watch on the collection is just a watch on the length of the
// collection. We don't care if the content changes.
scope.$watch(sfVirtualRepeatWatchExpression, sfVirtualRepeatListener, true);
Expand Down
4 changes: 4 additions & 0 deletions js/ext/angular/src/directive/ionicVirtualRepeat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,10 @@ angular.module('ionic.ui.virtualRepeat', [])
// When the user scrolls, we move the `state.firstActive`
dom.bind('momentumScrolled', sfVirtualRepeatOnScroll);

scope.$on('$destroy', function () {
dom.unbind('momentumScrolled', sfVirtualRepeatOnScroll);
});

// The watch on the collection is just a watch on the length of the
// collection. We don't care if the content changes.
scope.$watch(sfVirtualRepeatWatchExpression, sfVirtualRepeatListener, true);
Expand Down