fix(nav): insertPages method correctly inserts multiple pages with props

[liamdebeasi]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: fixes #21724

What is the new behavior?

Two issues that have been fixed:

1. insertPages now has correct types to indicate that you can insert multiple pages with props
2. cleanup method has been fixed to account for stack items that do not have DOM elements yet.

Does this introduce a breaking change?

• Yes
• No

Other information

[Yohandah]

I believe the method IonNav.setPages could use the same improvements as well ? Since it is not possible to use it with props as well

And I see you named the properties of the NavComponentWithProps type page and params, wouldn't make more sense to match .setRoot and .push and name them component and componentProps ?

[liamdebeasi]

Yeah probably. page and params is what we have been using internally for a while, but component and componentProps (or similar) makes more sense.