Skip to content

fix(vue): pages now render in correct outlet when using multiple nested outlets#22301

Merged
liamdebeasi merged 5 commits intomasterfrom
nested-outlet-vue
Oct 13, 2020
Merged

fix(vue): pages now render in correct outlet when using multiple nested outlets#22301
liamdebeasi merged 5 commits intomasterfrom
nested-outlet-vue

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 12, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22286

What is the new behavior?

  • Add checks in IonRouterOutlet to make sure that each outlet is only rendering content that should be rendered

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Oct 12, 2020
@liamdebeasi liamdebeasi merged commit 52f655c into master Oct 13, 2020
@liamdebeasi liamdebeasi deleted the nested-outlet-vue branch October 13, 2020 18:22
TakumaKira pushed a commit to TakumaKira/ionic-framework that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: multi tab setup causes pages to render in wrong outlet

1 participant