fix(refresher): force content to be ready before saving the scrollEl #22390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR. Can you sync your branch with the latest changes in |
liamdebeasi
suggested changes
Nov 2, 2020
| return; | ||
| } | ||
|
|
||
| await contentEl.componentOnReady(); |
Contributor
There was a problem hiding this comment.
If we add this here, then we should remove the componentOnReady call in https://github.com/ionic-team/ionic-framework/blob/master/core/src/components/refresher/refresher.tsx#L374 as it is redundant.
github-actions
bot
added
package: angular
Contributor
Author
|
@liamdebeasi done |
Contributor
|
Hmm it looks like it's trying to merge in all of the changes as new commits. It might be easier reset your branch to the latest master, make your change, then force push the updates. |
github-actions
bot
removed
package: angular
Contributor
Author
|
oh lol yeah i have seen it^^ did like you said: reset and the force pushed 😊 |
Contributor
|
Merged. Thank you! |
TakumaKira
pushed a commit
to TakumaKira/ionic-framework
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #22256
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #22256
Like wrote in the linked Issue, the Refresher sometimes starts too early / buggy when used in iOS card style modal. I debugged this today and saw, that the ScrollElement's offsetHeight could be zero here:
ionic-framework/core/src/components/refresher/refresher.tsx
Line 399 in c1455a8
This cause the
setupiOSNativeRefresherto not work properly, as MAX_PULL is zero then as well.What is the new behavior?
Does this introduce a breaking change?
Other information