Skip to content

fix(vue): adding non tab button elements inside ion-tab-bar no longer causes errors#22643

Merged
liamdebeasi merged 1 commit into
masterfrom
tab-bar-vue-check
Dec 8, 2020
Merged

fix(vue): adding non tab button elements inside ion-tab-bar no longer causes errors#22643
liamdebeasi merged 1 commit into
masterfrom
tab-bar-vue-check

Conversation

@liamdebeasi
Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22642

What is the new behavior?

  • Added a check to make sure we are looking at a tab button and that the element has a tab prop

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions Bot added the package: vue @ionic/vue package label Dec 8, 2020
@liamdebeasi liamdebeasi merged commit 61cf0c5 into master Dec 8, 2020
@liamdebeasi liamdebeasi deleted the tab-bar-vue-check branch December 8, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ionic vue non tab button elements in ion-tab-bar causes errors

1 participant