feat(datetime): add clear button to picker#22904
Closed
NiklasMerz wants to merge 1 commit intoionic-team:masterfrom
Closed
feat(datetime): add clear button to picker#22904NiklasMerz wants to merge 1 commit intoionic-team:masterfrom
NiklasMerz wants to merge 1 commit intoionic-team:masterfrom
Conversation
Contributor
|
Thanks for the PR! We appreciate the contribution to Ionic Framework. We are currently working on a complete overhaul of Adding this feature now would cause additional breaking changes when we release the updated As we get closer to the launch of the next major version of Ionic Framework we will have a public beta, so there will be an opportunity to test this feature and provide feedback. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The datetime component is missing a button to clear the value
Issue Number: #17482
What is the new behavior?
I hacked a new button in the picker, to see how complex this changed is. Looks like this can easily be done with a new button on the default picker.
I am not sure about the tests. Please let me know if and how to add tests for this new feature.
Does this introduce a breaking change?
Other information