Skip to content

docs(fab): document correct ion-icon usage for vue#23352

Merged
liamdebeasi merged 1 commit intomasterfrom
fab-usage
May 24, 2021
Merged

docs(fab): document correct ion-icon usage for vue#23352
liamdebeasi merged 1 commit intomasterfrom
fab-usage

Conversation

@liamdebeasi
Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

See: https://forum.ionicframework.com/t/ion-icon-not-visible-on-ion-fab-button/209961/3
Incorrect ion-icon usage was documented for vue, so icons were not showing up.

What is the new behavior?

  • Switched example to use local icon registration in the fab docs

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions Bot added the package: core @ionic/core package label May 24, 2021
@liamdebeasi liamdebeasi merged commit bc2f1b8 into master May 24, 2021
@liamdebeasi liamdebeasi deleted the fab-usage branch May 24, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant