Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

We no longer run the Stencil E2E tests, so I removed the step from the stencil eval file.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL:

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

We no longer run the Stencil E2E tests, so I removed the step from the stencil eval file.
@liamdebeasi liamdebeasi marked this pull request as ready for review December 8, 2022 15:17
@liamdebeasi liamdebeasi requested a review from a team as a code owner December 8, 2022 15:17
@liamdebeasi liamdebeasi removed the request for review from a team December 8, 2022 15:17
Copy link
Contributor

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🙏 🙏

@liamdebeasi liamdebeasi merged commit 6309133 into main Dec 8, 2022
@liamdebeasi liamdebeasi deleted the liamdebeasi-patch-2 branch December 8, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants