Skip to content

Conversation

@sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Dec 9, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Disabling flaky test

What is the current behavior?

The test to change the time picker value and verify the updated text is flaky: https://github.com/ionic-team/ionic-framework/actions/runs/3652722081/jobs/6171464242

The test to verify visual regressions on the picker internal is flaky: https://github.com/ionic-team/ionic-framework/actions/runs/3659143552/jobs/6184886926

Issue URL: N/A

What is the new behavior?

  • Skips the test for now.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Dec 9, 2022
@sean-perkins sean-perkins changed the title test(datetime): skip flaky time presentation test test(datetime,picker-internal): skip flaky tests Dec 9, 2022
@sean-perkins sean-perkins marked this pull request as ready for review December 9, 2022 18:33
@sean-perkins sean-perkins requested a review from a team as a code owner December 9, 2022 18:33
@liamdebeasi liamdebeasi changed the title test(datetime,picker-internal): skip flaky tests test(datetime, picker-internal): skip flaky tests Dec 9, 2022
@sean-perkins sean-perkins merged commit c5ebc91 into main Dec 9, 2022
@sean-perkins sean-perkins deleted the fix/disable-datetime-time-test branch December 9, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants