-
Notifications
You must be signed in to change notification settings - Fork 13.4k
refactor(config): remove stencil extras #26461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Blocked on #26454 |
sean-perkins
approved these changes
Dec 9, 2022
averyjohnston
approved these changes
Dec 9, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs PR: ionic-team/ionic-docs#2676
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The Stencil team would like to deprecate the
extrasoption in Stencil v3.What is the new behavior?
Bumped the minimum Firefox version for v7 from Firefox v63 to v70. I chose v70 because it gives us ~3 years of Firefox browser support.
These
extrasoptions have been removed:dynamicImportShim: Only needed on <= Edge 18 and <= Firefox 67 according to https://stenciljs.com/docs/config-extras#dynamicimportshiminitializeNextTick: This is needed to work around an old Angular issue, though that issue is possibly no longer a problem. We should observe any negative side effects during the v7 beta.scriptDataOpts: This lets you calldefineCustomElementsfrom a vanilla JS app and a) load Ionic from a CDN and b) provide a config. This is not used anymore and our docs recommend adding the script tags yourself: https://ionicframework.com/docs/intro/cdnDoes this introduce a breaking change?
Other information
Note: Removing
initializeNextTickcaused a visual diff in Safari with iOS mode/RTL direction that I was unable to identify the root cause for. Some of the text initem/test/fillappears to be clipped by 1-2px. I am unable to reproduce this locally, so I decided it would be best to process despite this diff:I have updated the screenshot test with the new diff that way we a) still get test covered for iOS mode/RTL direction on Safari and b) catch any diffs if this changes again.
Ryan believes this may be
connectedCallback-related with a possible timing issue: