Skip to content

fix(menu, split-pane): ssr does not fail on null customElements check #26854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 2, 2023
Merged

fix(menu, split-pane): ssr does not fail on null customElements check #26854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d354037
fix(menu, split-pane): add checks for ssr
liamdebeasi Feb 23, 2023
2905db0
try a null check
liamdebeasi Feb 23, 2023
ed3340f
Merge branch 'main' into FW-798
liamdebeasi Feb 27, 2023
2e9bb77
Merge branch 'main' into FW-798
liamdebeasi Feb 27, 2023
78c0a68
Merge branch 'main' into FW-798
liamdebeasi Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/components/menu/menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ export class Menu implements ComponentInterface, MenuI {
async connectedCallback() {
// TODO: connectedCallback is fired in CE build
// before WC is defined. This needs to be fixed in Stencil.
if (typeof (customElements as any) !== 'undefined') {
if (typeof (customElements as any) !== 'undefined' && (customElements as any) != null) {
await customElements.whenDefined('ion-menu');
}

Expand Down
2 changes: 1 addition & 1 deletion core/src/components/split-pane/split-pane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class SplitPane implements ComponentInterface {
async connectedCallback() {
// TODO: connectedCallback is fired in CE build
// before WC is defined. This needs to be fixed in Stencil.
if (typeof (customElements as any) !== 'undefined') {
if (typeof (customElements as any) !== 'undefined' && (customElements as any) != null) {
await customElements.whenDefined('ion-split-pane');
}
this.styleChildren();
Expand Down