test(modal): migrate to generators #27331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
2 tasks
2 tasks
2 tasks
averyjohnston
approved these changes
May 5, 2023
liamdebeasi
added a commit
that referenced
this pull request
May 8, 2023
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When doing #27331 I noticed a noticeable increase in the amount of time it took to run all the modal tests. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> b290772 - The a11y custom role E2E test was ported to a spec test. dd9e2bc - The htmlAttributes e2e test was ported to a spec test fa348ea - The e2e tests that looked at basic functionality of canDismiss were ported to spec tests (tests that check canDismiss when swiping remain as e2e tests) 325b115 - The basic rendering test checks LTR and RTL rendering for the card modal. However, the other scenarios such as stacked cards, custom modals, tablet viewport, etc does not have RTL-specific behavior. As a result, I removed the RTL checks/screenshots. The basic test continues to check LTR/RTL. 0428630 - The card tests were still slow after making the previous change, so I broke the mobile and tablet tests up into multiple files so they can be parallelized on CI better. e5236c0 - The sheet functionality tests do not vary across modes, so I removed the extra check. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Modal tests are using legacy syntax
What is the new behavior?
e3e83ef
Does this introduce a breaking change?
Other information
Note: Some of these tests are quite slow, so you may see a CI slowdown if this merges. However, I am working on addressing this in #27397.