Skip to content

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Jul 21, 2023

Issue number: N/A


What is the current behavior?

All the E2E tests are run when performing the "Update Reference Screenshots" GitHub actions.

Screenshot 2024-01-25 at 1 31 15 PM

What is the new behavior?

  • All E2E tests still run as default.
  • The GH action has the option to run a specific component instead of all tests.
    • A specified component has the option to run all tests that include the component's name in the file path
    • A specified component has the option to run all tests that are in the component's folder
  • If a single component is selected, then the default is to only run tests inside it's folder.

Screenshot 2024-01-25 at 1 30 34 PM

Does this introduce a breaking change?

  • Yes
  • No

Other information

How to test:

  1. Create a new branch based off this one
  2. Make a style change
  3. Push it to the new branch
  4. Update the reference images using the new branch
  5. This will show you all the options

Recommended to test:

  • a component with the ion prefix (ion-button)
  • a component without the prefix (button)
  • a component that doesn't exist (random-component)
  • no provided component, leave the first input blank
  • the checkbox

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@thetaPC thetaPC changed the title refactor(screenshots): run a single component refactor(ga-screenshots): run a single component Jul 21, 2023
@thetaPC thetaPC changed the title refactor(ga-screenshots): run a single component refactor(ga-screenshots): option to test single component Jul 21, 2023
@thetaPC thetaPC marked this pull request as ready for review July 21, 2023 16:58
@thetaPC thetaPC requested review from a team and sean-perkins and removed request for a team July 21, 2023 16:58
shard: ${{ matrix.shard }}
totalShards: ${{ matrix.totalShards }}
update: true
component: ${{ inputs.component}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ nit: Can we format these variables to have equal whitespacing?

e.g.:

component: ${{ inputs.component }}
component-folder: ${{ inputs.component-folder }}

@thetaPC thetaPC requested a review from sean-perkins August 10, 2023 15:24
@sean-perkins
Copy link
Contributor

I think this might need a little more testing and exploration. Here's an example run I did on a fork of this branch: https://github.com/ionic-team/ionic-framework/actions/runs/5943476177/job/16118770162

I modified two components (button and radio) and ran this job against the branch, filtering on button.

Let me know if you have any questions!

@thetaPC
Copy link
Contributor Author

thetaPC commented Aug 22, 2023

I think this might need a little more testing and exploration. Here's an example run I did on a fork of this branch: https://github.com/ionic-team/ionic-framework/actions/runs/5943476177/job/16118770162

I modified two components (button and radio) and ran this job against the branch, filtering on button.

Let me know if you have any questions!

Got it! I'll look into this more. Thank you!

@sean-perkins
Copy link
Contributor

I'm going to remove myself from review. Feel free to re-add me once it is ready for another look!

@sean-perkins sean-perkins removed their request for review August 31, 2023 16:51
component:
description: 'The component to update the reference snapshots'
component-folder:
description: 'The component folder to update the reference snapshots'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description does not align with it's type (boolean). Should this match the description from update-screenshots.yml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, the updated description is better.

@thetaPC thetaPC requested a review from sean-perkins November 17, 2023 19:48
@thetaPC thetaPC requested a review from a team December 18, 2023 19:09
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
@thetaPC thetaPC added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit aecbc92 Jan 26, 2024
@thetaPC thetaPC deleted the ga-screenshots-component branch January 26, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants