-
Notifications
You must be signed in to change notification settings - Fork 13.4k
refactor(ga-screenshots): option to test single component #27841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
| shard: ${{ matrix.shard }} | ||
| totalShards: ${{ matrix.totalShards }} | ||
| update: true | ||
| component: ${{ inputs.component}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~ nit: Can we format these variables to have equal whitespacing?
e.g.:
component: ${{ inputs.component }}
component-folder: ${{ inputs.component-folder }}
|
I think this might need a little more testing and exploration. Here's an example run I did on a fork of this branch: https://github.com/ionic-team/ionic-framework/actions/runs/5943476177/job/16118770162 I modified two components (button and radio) and ran this job against the branch, filtering on button. Let me know if you have any questions! |
Got it! I'll look into this more. Thank you! |
|
I'm going to remove myself from review. Feel free to re-add me once it is ready for another look! |
| component: | ||
| description: 'The component to update the reference snapshots' | ||
| component-folder: | ||
| description: 'The component folder to update the reference snapshots' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description does not align with it's type (boolean). Should this match the description from update-screenshots.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully, the updated description is better.
liamdebeasi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Issue number: N/A
What is the current behavior?
All the E2E tests are run when performing the "Update Reference Screenshots" GitHub actions.
What is the new behavior?
Does this introduce a breaking change?
Other information
How to test:
Recommended to test:
ion-button)button)random-component)