chore: sync with main #28328
Merged
chore: sync with main #28328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…28294) Issue number: resolves #28293 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Disabled toggles, radios, and checkboxes can still be enabled by manually dispatching a click event on them. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Toggles, radios, and checkboxes no longer activate if `disabled` is set to `true` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `7.4.4-dev.11696545130.1171e7a9`
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.4.0 to 4.4.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h2>❤️ <a href="https://github.com/ionic-team/stencil/compare/v4.4.0...v4.4.1">4.4.1</a> (2023-10-09)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>screenshot:</strong> alert user when toMatchScreenshot uses NaN (<a href="https://redirect.github.com/ionic-team/stencil/issues/4891">#4891</a>) (<a href="https://github.com/ionic-team/stencil/commit/a251946106f116701787853893b3fa53dfaa8c9f">a251946</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/0f522244faaae97a2f5fcb9ba5fe148479465e5a"><code>0f52224</code></a> v4.4.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4918">#4918</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/2874e9d8d9056124aecda3315cebdeaacaf081d7"><code>2874e9d</code></a> chore(deps): update dependency terser to v5.21.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4913">#4913</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/f008213dae2bff923af9a269be02f7e1bac2e6e6"><code>f008213</code></a> chore(deps): update typescript-eslint to v6.7.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4911">#4911</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/0aae1d8fe2ea6213daa9d5d7fc301638b67de35a"><code>0aae1d8</code></a> chore(deps): update dependency <code>@rollup/plugin-json</code> to v6.0.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4906">#4906</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/c523f1c678205cfba77fc8210cc9a3bc9a5abe0e"><code>c523f1c</code></a> chore(deps): update dependency <code>@types/node</code> to v20.8.2 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4910">#4910</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/abe407d49ce7ebccdc182d5f7e98e04344348581"><code>abe407d</code></a> chore(compiler): add namespace to validated config (<a href="https://redirect.github.com/ionic-team/stencil/issues/4902">#4902</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/8d0360666e84d9c7262bb321bdf1af487c1178e4"><code>8d03606</code></a> chore(test): document dynamic import of testing submodule (<a href="https://redirect.github.com/ionic-team/stencil/issues/4885">#4885</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a251946106f116701787853893b3fa53dfaa8c9f"><code>a251946</code></a> fix(screenshot): alert user when toMatchScreenshot uses NaN (<a href="https://redirect.github.com/ionic-team/stencil/issues/4891">#4891</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/8129089603bc61d50bf6385a6874add8a0991c01"><code>8129089</code></a> chore(deps): update dependency eslint-plugin-jest to v27.4.2 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4894">#4894</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/50fdccdd42271995b2a766c29917f86cc32880e0"><code>50fdccd</code></a> chore(deps): update nick-fields/retry action to v2.9.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/4896">#4896</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.4.0...v4.4.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue number: resolves #28284 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Select focuses the first popover option when no value is provided. This means that the first option is focused even if it disabled. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Select focuses the first **enabled** popover option when no value is provided. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> --------- Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com>
Release 7.4.4
github-actions
bot
added
package: core
liamdebeasi
requested review from
averyjohnston,
sean-perkins and
thetaPC
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information