Skip to content

chore(test-apps): improve developer message with test apps #28917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2024
Merged

chore(test-apps): improve developer message with test apps #28917

merged 1 commit into from
Jan 31, 2024

Conversation

@sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Jan 30, 2024

Issue number: N/A

What is the current behavior?

What is the new behavior?

  • Improves the developer message when generating a test app to include the next steps to running the test app.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: angular @ionic/angular package package: vue @ionic/vue package package: react @ionic/react package labels Jan 30, 2024
@sean-perkins sean-perkins marked this pull request as ready for review January 30, 2024 02:55
thetaPC
thetaPC approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

averyjohnston
averyjohnston approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sean-perkins sean-perkins merged commit fb48489 into workspace-test Jan 31, 2024
@sean-perkins sean-perkins deleted the sp/build-scripts branch January 31, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPC thetaPC thetaPC approved these changes

+1 more reviewer

@averyjohnston averyjohnston averyjohnston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: angular @ionic/angular package package: react @ionic/react package package: vue @ionic/vue package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sean-perkins @thetaPC @averyjohnston