Skip to content

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Feb 2, 2024

Issue number: internal


What is the current behavior?

The Readmes are all using npm in the building sections.

What is the new behavior?

  • The Readmes are all using pnpm in the building sections.

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@github-actions github-actions bot added package: angular @ionic/angular package package: vue @ionic/vue package package: react @ionic/react package labels Feb 2, 2024
@thetaPC thetaPC marked this pull request as ready for review February 2, 2024 00:35
@thetaPC thetaPC requested review from a team, averyjohnston and liamdebeasi as code owners February 2, 2024 00:35
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the current changes. If we need to tweak any language/steps in the future, we can always do that.

Thanks for updating these!

@thetaPC thetaPC merged commit 7241632 into workspace-test Feb 2, 2024
@thetaPC thetaPC deleted the update-readmes branch February 2, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: react @ionic/react package package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants