Release 7.7.2 #29053
Merged
Release 7.7.2 #29053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 7.7.1
Issue number: resolves #28985 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> <!-- Please describe the current behavior that you are modifying. --> When a popover is being rendered in iOS mode, the arrow renders under the backdrop.  <!-- Please describe the behavior or changes that are being added by this PR. --> - The arrow renders at the same level as the content.  - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Credit [Sahil-B07](https://github.com/Sahil-B07) for providing the [fix](#28430). A new PR had to be created in order to update snapshots. --------- Co-authored-by: Sahil Bhor <92709590+Sahil-B07@users.noreply.github.com> Co-authored-by: ionitron <hi@ionicframework.com>
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.12.0 to 4.12.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🏸 v4.12.1 (2024-02-05)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>mock-doc:</strong> improve error message when <code>:scope</code> selector is used (<a href="https://redirect.github.com/ionic-team/stencil/issues/5318">#5318</a>) (<a href="https://github.com/ionic-team/stencil/commit/f5d4e98d0e12a218e8b2f472853905975b964e02">f5d4e98</a>)</li> <li><strong>runtime:</strong> dynamic slot name change (<a href="https://redirect.github.com/ionic-team/stencil/issues/5304">#5304</a>) (<a href="https://github.com/ionic-team/stencil/commit/9d9fe419c669b0e85c00ce9e65ac22d564c51d9c">9d9fe41</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/2982">#2982</a></li> <li><strong>runtime:</strong> only generate lazy build CSS when there are component tags (<a href="https://redirect.github.com/ionic-team/stencil/issues/5305">#5305</a>) (<a href="https://github.com/ionic-team/stencil/commit/a0c1bd0f91938f7f3cfc97cc5402d3ff955d327f">a0c1bd0</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3771">#3771</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h2>🏸 <a href="https://github.com/ionic-team/stencil/compare/v4.12.0...v4.12.1">4.12.1</a> (2024-02-05)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>mock-doc:</strong> improve error message when <code>:scope</code> selector is used (<a href="https://redirect.github.com/ionic-team/stencil/issues/5318">#5318</a>) (<a href="https://github.com/ionic-team/stencil/commit/f5d4e98d0e12a218e8b2f472853905975b964e02">f5d4e98</a>)</li> <li><strong>runtime:</strong> dynamic slot name change (<a href="https://redirect.github.com/ionic-team/stencil/issues/5304">#5304</a>) (<a href="https://github.com/ionic-team/stencil/commit/9d9fe419c669b0e85c00ce9e65ac22d564c51d9c">9d9fe41</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/2982">#2982</a></li> <li><strong>runtime:</strong> only generate lazy build CSS when there are component tags (<a href="https://redirect.github.com/ionic-team/stencil/issues/5305">#5305</a>) (<a href="https://github.com/ionic-team/stencil/commit/a0c1bd0f91938f7f3cfc97cc5402d3ff955d327f">a0c1bd0</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3771">#3771</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/f9df928d476dfee50ca80b9b0421a1079325e1f7"><code>f9df928</code></a> Release v4.12.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5332">#5332</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/d3083c09c8f2cd65597540265da90892f9e2dc76"><code>d3083c0</code></a> chore(deps): update dependency webpack to v5.90.1 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5325">#5325</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/125d4a591723511b163ff4c52a8f128f4af8686e"><code>125d4a5</code></a> chore(deps): update dependency <code>@types/node</code> to v20.11.16 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5322">#5322</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/043ad48f450a3bef119de5f84299897bf5a14a29"><code>043ad48</code></a> chore(deps): update typescript-eslint to v6.20.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5327">#5327</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/3b90f88f1e3677db1886153ed24862ccd9196acd"><code>3b90f88</code></a> chore(deps): update peter-evans/create-pull-request action to v6 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5330">#5330</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/596674b0db6c5c7ca356f5b1559a542e5f801953"><code>596674b</code></a> chore(deps): update dependency eslint-plugin-jsdoc to v48.0.4 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5323">#5323</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/e25255f107ff8750ca3c80b05423062b36286072"><code>e25255f</code></a> chore(deps): update dependency puppeteer to v21.10.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5326">#5326</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/03f6759abfc5a57d56846a0a10934049e9c01e38"><code>03f6759</code></a> chore(deps): update nick-fields/retry action to v3 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5328">#5328</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/cf9554d02b9cdd8ad001f231e1a4d6c537326a2b"><code>cf9554d</code></a> chore(deps): update dependency magic-string to v0.30.6 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5324">#5324</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/be9b1f0c4381b2823b8afb0a850d1cd1dcd06034"><code>be9b1f0</code></a> chore(deps): update dependency <code>@types/jest</code> to v29.5.12 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5321">#5321</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.12.0...v4.12.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
In #28981 there was some confusion surrounding how to remove an overlay from the DOM if it was never presented. The `dismiss` method will remove the overlay from the DOM, but only if the overlay is visible. Otherwise, it's a no-op. This PR updates the `dismiss` method docs for each overlay component to note that developers can use the browser's remove method to remove the element from the DOM.
Issue number: Internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Team members are running into unexpected errors running spec tests: ``` TypeError: Cannot read properties of undefined (reading '$instanceValues$') ``` This line is the culprit: https://github.com/ionic-team/ionic-framework/blob/f885a5526addab8abf93a95de8980e4ef78cbd36/core/src/components/toast/test/toast.spec.tsx#L108 We set the Ionic config for toastDuration to 5000. This means that on present a setTimeout callback will fire after 5000ms and dismiss the toast. For this test, this is fine because we never present the toast therefore the setTimeout is never created. The problem is that this config is not automatically reset between tests. As a result, when we have tests that only present the toast (and never dismiss it) the duration is also 5000 there: https://github.com/ionic-team/ionic-framework/blob/f885a5526addab8abf93a95de8980e4ef78cbd36/core/src/components/toast/test/toast.spec.tsx#L179-L184 This results in a bunch of setTimeouts being created. The timeout callback runs dismiss, and the body of that function tries to access data on the host toast. Since the toast instance has already been torn down (since the tests are done), the undefined error occurs. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Reset the Ionic config after the test that sets `toastDuration` to `5000` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
…28998) Bumps [@capacitor/core](https://github.com/ionic-team/capacitor) from 5.6.0 to 5.7.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor/releases"><code>@capacitor/core</code>'s releases</a>.</em></p> <blockquote> <h2>5.7.0</h2> <h1><a href="https://github.com/ionic-team/capacitor/compare/5.6.0...5.7.0">5.7.0</a> (2024-02-07)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>cli:</strong> correctly build and sign Android apps using Flavors (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7211">#7211</a>) (<a href="https://github.com/ionic-team/capacitor/commit/af97904d05d5a735a341110816b1845bdd90de0a">af97904</a>)</li> <li><strong>http:</strong> better handling of active requests and shutting down gracefully (<a href="https://github.com/ionic-team/capacitor/commit/a56e84546d1a05ef5f2c346b6110372abf19637e">a56e845</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>webview:</strong> add setServerAssetPath method (<a href="https://github.com/ionic-team/capacitor/commit/4e8449c1b570ceb65a4ec2967a7db5dbda9a5688">4e8449c</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/capacitor/blob/5.7.0/CHANGELOG.md"><code>@capacitor/core</code>'s changelog</a>.</em></p> <blockquote> <h1><a href="https://github.com/ionic-team/capacitor/compare/5.6.0...5.7.0">5.7.0</a> (2024-02-07)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>cli:</strong> correctly build and sign Android apps using Flavors (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7211">#7211</a>) (<a href="https://github.com/ionic-team/capacitor/commit/af97904d05d5a735a341110816b1845bdd90de0a">af97904</a>)</li> <li><strong>http:</strong> better handling of active requests and shutting down gracefully (<a href="https://github.com/ionic-team/capacitor/commit/a56e84546d1a05ef5f2c346b6110372abf19637e">a56e845</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>webview:</strong> add setServerAssetPath method (<a href="https://github.com/ionic-team/capacitor/commit/4e8449c1b570ceb65a4ec2967a7db5dbda9a5688">4e8449c</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/capacitor/commit/e1a358d07105d4930fdf35b5dbd7d6dc09c311a9"><code>e1a358d</code></a> Release 5.7.0</li> <li><a href="https://github.com/ionic-team/capacitor/commit/a56e84546d1a05ef5f2c346b6110372abf19637e"><code>a56e845</code></a> fix(http): better handling of active requests and shutting down gracefully</li> <li><a href="https://github.com/ionic-team/capacitor/commit/af97904d05d5a735a341110816b1845bdd90de0a"><code>af97904</code></a> fix(cli): correctly build and sign Android apps using Flavors (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7211">#7211</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/bbba372adfd7257a152ca90047eea14d73042745"><code>bbba372</code></a> chore(android): Deprecate PluginCall hasOption (<a href="https://redirect.github.com/ionic-team/capacitor/issues/7212">#7212</a>)</li> <li><a href="https://github.com/ionic-team/capacitor/commit/4e8449c1b570ceb65a4ec2967a7db5dbda9a5688"><code>4e8449c</code></a> feat(webview): add setServerAssetPath method</li> <li>See full diff in <a href="https://github.com/ionic-team/capacitor/compare/5.6.0...5.7.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n readers (#28997) Issue number: resolves #23472 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> If multiple overlays are presented at the same time, none of them receive `aria-hidden="true"`. This means that screen readers can read contents from overlays behind the current one, which can be confusing for users. The original issue also reports router outlets getting `aria-hidden` removed when any overlay is dismissed, not just the last one, but we've since fixed that: https://github.com/ionic-team/ionic-framework/blob/35ab6b4816bd627239de8d8b25ce0c86db8c74b4/core/src/utils/overlays.ts#L573-L576 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> All overlays besides the topmost one now receive `aria-hidden="true"`. This means that screen readers will only announce the topmost overlay. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
Bumps [@stencil/core](https://github.com/ionic-team/stencil) from 4.12.1 to 4.12.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/releases"><code>@stencil/core</code>'s releases</a>.</em></p> <blockquote> <h2>🎯 v4.12.2 (2024-02-12)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> support async globalScripts functions (<a href="https://redirect.github.com/ionic-team/stencil/issues/5158">#5158</a>) (<a href="https://github.com/ionic-team/stencil/commit/8a129ce7342ba737db70e0db6eda088cc9461d7f">8a129ce</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3392">#3392</a></li> <li><strong>mock-doc:</strong> overwrite parentElement in MockHTMLElement to return null (<a href="https://redirect.github.com/ionic-team/stencil/issues/5336">#5336</a>) (<a href="https://github.com/ionic-team/stencil/commit/0d9ed22c807b1788244258d6cf5eef7c6c637e43">0d9ed22</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/5252">#5252</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ionic-team/stencil/blob/main/CHANGELOG.md"><code>@stencil/core</code>'s changelog</a>.</em></p> <blockquote> <h2>🎯 <a href="https://github.com/ionic-team/stencil/compare/v4.12.1...v4.12.2">4.12.2</a> (2024-02-12)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>compiler:</strong> support async globalScripts functions (<a href="https://redirect.github.com/ionic-team/stencil/issues/5158">#5158</a>) (<a href="https://github.com/ionic-team/stencil/commit/8a129ce7342ba737db70e0db6eda088cc9461d7f">8a129ce</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/3392">#3392</a></li> <li><strong>mock-doc:</strong> overwrite parentElement in MockHTMLElement to return null (<a href="https://redirect.github.com/ionic-team/stencil/issues/5336">#5336</a>) (<a href="https://github.com/ionic-team/stencil/commit/0d9ed22c807b1788244258d6cf5eef7c6c637e43">0d9ed22</a>), closes <a href="https://redirect.github.com/ionic-team/stencil/issues/5252">#5252</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ionic-team/stencil/commit/fc85b1f524ab42946a558241ec0c8e72b8fb71f4"><code>fc85b1f</code></a> Release v4.12.2 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5355">#5355</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/e8bf8968f1394a7411aecbe8817076ed8c9dc03d"><code>e8bf896</code></a> chore(deps): update dependency semver to v7.6.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5351">#5351</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9a94671805921dd84fdc8e0848c7e23c1b790d38"><code>9a94671</code></a> chore(deps): update dependency <code>@types/node</code> to v20.11.17 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5346">#5346</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/3d0514b019b262bdbb9970d204a968ee78e178be"><code>3d0514b</code></a> chore(deps): update dependency eslint-plugin-jsdoc to v48.0.6 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5347">#5347</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/9c70f3dce902bb593180ca5f6a39b2e9bdfde60f"><code>9c70f3d</code></a> chore(deps): update actions/setup-node action to v4.0.2 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5345">#5345</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/a5a3304dbf9479aeb9e205f76fd6e8b034e07353"><code>a5a3304</code></a> chore(deps): update dependency magic-string to v0.30.7 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5348">#5348</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/20286c0735ee5dd7bd9e6b8a2a719d240e7d35ae"><code>20286c0</code></a> chore(deps): update download + upload artifacts (<a href="https://redirect.github.com/ionic-team/stencil/issues/5350">#5350</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/d05a133ee5445c3a15553d81d74c62e95e65043d"><code>d05a133</code></a> chore(deps): update typescript-eslint to v6.21.0 (<a href="https://redirect.github.com/ionic-team/stencil/issues/5352">#5352</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/0d9ed22c807b1788244258d6cf5eef7c6c637e43"><code>0d9ed22</code></a> fix(mock-doc): overwrite parentElement in MockHTMLElement to return null (<a href="https://redirect.github.com/ionic-team/stencil/issues/5336">#5336</a>)</li> <li><a href="https://github.com/ionic-team/stencil/commit/8a129ce7342ba737db70e0db6eda088cc9461d7f"><code>8a129ce</code></a> fix(compiler): support async globalScripts functions (<a href="https://redirect.github.com/ionic-team/stencil/issues/5158">#5158</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ionic-team/stencil/compare/v4.12.1...v4.12.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ocus manually (#28850) Issue number: resolves #28849 --------- ## What is the current behavior? If the developer tries to set focus to a custom element on overlay dismissal, Ionic will always override that focus. ## What is the new behavior? - If focus is already set by developer during dismissal, then Ionic will not restore focus to previous element ## Does this introduce a breaking change? - [ ] Yes - [x] No ## Other information In the before video, you can see the text box is focused by developer code when "Mention User" is tapped, which opens the keyboard. Shortly after that, when the bottom sheet fully dismisses, Ionic focuses the button, removing focus from the text box and hiding the keyboard. In the after, Ionic detects that the developer has already focused the text box and does not change that focus. |Before|After| |---|---| |<video src="https://github.com/ionic-team/ionic-framework/assets/2166114/47d55eff-29af-4019-ac3c-00f9fe722ca7"></video>| <video src="https://github.com/ionic-team/ionic-framework/assets/2166114/508ae466-d037-41eb-b518-92338a122b22"></video>|
…re (#29026) Bumps [@axe-core/playwright](https://github.com/dequelabs/axe-core-npm) from 4.8.4 to 4.8.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dequelabs/axe-core-npm/releases"><code>@axe-core/playwright</code>'s releases</a>.</em></p> <blockquote> <h2>Release 4.8.5</h2> <h2>What's Changed</h2> <ul> <li>ci: fix github release script by <a href="https://github.com/michael-siek"><code>@michael-siek</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/999">dequelabs/axe-core-npm#999</a></li> <li>chore: merge master into develop by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/998">dequelabs/axe-core-npm#998</a></li> <li>chore: update chromedriver to 121 by <a href="https://github.com/michael-siek"><code>@michael-siek</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/1005">dequelabs/axe-core-npm#1005</a></li> <li>fix: Update axe-core to v4.8.4 by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/1008">dequelabs/axe-core-npm#1008</a></li> <li>ci: fix tagging when creating releases by <a href="https://github.com/michael-siek"><code>@michael-siek</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/1012">dequelabs/axe-core-npm#1012</a></li> <li>chore: RC v4.8.5 by <a href="https://github.com/github-actions"><code>@github-actions</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/1013">dequelabs/axe-core-npm#1013</a></li> <li>Release v4.8.5 by <a href="https://github.com/dequejenn"><code>@dequejenn</code></a> in <a href="https://redirect.github.com/dequelabs/axe-core-npm/pull/1015">dequelabs/axe-core-npm#1015</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/dequelabs/axe-core-npm/compare/v4.8.4...v4.8.5">https://github.com/dequelabs/axe-core-npm/compare/v4.8.4...v4.8.5</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/dequelabs/axe-core-npm/blob/develop/CHANGELOG.md"><code>@axe-core/playwright</code>'s changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/dequelabs/axe-core-npm/compare/v4.8.4...v4.8.5">4.8.5</a> (2024-02-08)</h2> <h3>Bug Fixes</h3> <ul> <li>Update axe-core to v4.8.4 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/1008">#1008</a>) (<a href="https://github.com/dequelabs/axe-core-npm/commit/d54f145a4078c4730a850e694c9eb77297c23a35">d54f145</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/1540d5aed5f0642739551862dfebb6a82cc78f09"><code>1540d5a</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/1015">#1015</a> from dequelabs/release</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/8c4ea105659a7011fc0aa319aa27811bc25380e2"><code>8c4ea10</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/1013">#1013</a> from dequelabs/release-2024-02-08</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/2a68996eef37847640faa60f48453684d74cf4d9"><code>2a68996</code></a> chore: RC v4.8.5</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/bc94e81101a84d9b1c3c91d9d94649173168cfaa"><code>bc94e81</code></a> ci: fix tagging when creating releases (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/1012">#1012</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/d54f145a4078c4730a850e694c9eb77297c23a35"><code>d54f145</code></a> fix: Update axe-core to v4.8.4 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/1008">#1008</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/04b0f1bd864ede05f9ab5962974aabdb4aa0e6c6"><code>04b0f1b</code></a> chore: update chromedriver to 121 (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/1005">#1005</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/38e440c24627b4f7316f9d04a1e05803a2c5d5d6"><code>38e440c</code></a> chore: merge master into develop (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/998">#998</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/67119354626eacc1208da13c8d71570a0cf0e4f1"><code>6711935</code></a> ci: fix github release script (<a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/999">#999</a>)</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/4b97eb6d3aa1e39eba920208f8f8691fa86347c8"><code>4b97eb6</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/997">#997</a> from dequelabs/release</li> <li><a href="https://github.com/dequelabs/axe-core-npm/commit/39c64e9b4363a395be59e4a7fa507142553e0cf9"><code>39c64e9</code></a> Merge pull request <a href="https://redirect.github.com/dequelabs/axe-core-npm/issues/995">#995</a> from dequelabs/release-2024-01-23</li> <li>Additional commits viewable in <a href="https://github.com/dequelabs/axe-core-npm/compare/4.8.4...v4.8.5">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Fix Internal issue (FW-5205) - Removed the build conditional in the `item` component since the previous issue is already fixed in Stencil. --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> - No changes were made in terms of behavior. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - No changes were made in terms of behavior so it will work as before. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> - Spec tests still pass even after this change (we can see below the results before and after the change) - Ran the command `npm run test.spec src/components/item/test/item.spec.ts src/components/item/test/item.spec.tsx` 
GitHub Actions is [transitioning from Node 16 to Node 20](https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/). As a result, we have several GitHub Actions that need to be updated. Rather than update these actions manually, I decided to have Renovatebot do it. This PR adds Renovatebot so it can automatically create PRs to update our GitHub Actions dependencies. I also migrated the Dependabot config to use Renovatebot so we don't have two dependency management tools. Example test run: https://github.com/liamdebeasi/framework-renovate-test/pulls Note: You can ignore the Docker update. I am using this fork for Docker-related work as well. As a result of this PR, Renovatebot will create several PRs on this repo to update GitHub Actions dependencies.
github-actions
bot
added
package: core
liamdebeasi
requested review from
a team,
averyjohnston,
brandyscarney,
sean-perkins and
thetaPC
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information